Add datepicker to filters with datetime & date input fields (Meta #124)
#61
Conversation
There was a problem hiding this comment.
@marcwieland95 I think you should ask someone additional for a review on the PHP part here. I'm not a PHP developer and can barely validate the code health here. The only part I can tell for sure is that the HTML probably should be moved to Twig.
|
|
||
| return sprintf( | ||
| '<input type="datetime-local" name="{name}" value="%s">', | ||
| $operator !== static::CRITERIA_IS_EMPTY ? $value : '' | ||
| '<input type="datetime-local" name="{name}" value="%s" data-controller="araise--core-bundle--datetime" data-araise--core-bundle--datetime-lang-value="%s">', |
src/Filter/Type/DateFilterType.php
Outdated
| public function getValueField(?string $value = null, ?string $operator = null): string | ||
| { | ||
| $date = \DateTime::createFromFormat(static::getQueryDataFormat(), (string) $value) ?: new \DateTime(); | ||
| $value = $date->format(static::getDateFormat()); | ||
|
|
||
| return sprintf( | ||
| '<input type="date" name="{name}" value="%s">', | ||
| $operator !== static::CRITERIA_IS_EMPTY ? $value : '' | ||
| '<input type="date" name="{name}" value="%s" data-controller="araise--core-bundle--datetime" data-araise--core-bundle--datetime-lang-value="%s">', |
There was a problem hiding this comment.
@renestalder Technically yes, but Symfony itself on other types also isn't doing that for input or select fields.
I see the issue with writting Stimulus controllers/values which aren't readable. But that's how messy Stimulus is without a helper function. Since Symfony has this helper functions for TWIG, we should also be able to access it here in PHP. I'll have a look into that.
There was a problem hiding this comment.
Had no time to look into that. Made a note for later for myself
There was a problem hiding this comment.
@marcwieland95 you could use the StimulusHelper
marcwieland95
force-pushed
the
feature/124-filter-datepicker
branch
from
0cb8191
to
e702cb0
Compare
|
Assigned @tuxes3 for a review, as this needs a PHP developer to look at the changes. |
I had to handle the requestStack retrieval differently between those two classes. Don't know why this is the case.
tuxes3
force-pushed
the
feature/124-filter-datepicker
branch
from
e702cb0
to
72b3966
Compare
There was a problem hiding this comment.
@marcwieland95 I rebased the branch, applied our codestyle and tested the implementation in our demo app. LGTM
No description provided.